Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter out CSS files from middleware files and client reference chunks #57482

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Filter out CSS files from middleware files and client reference chunks #57482

merged 1 commit into from
Oct 26, 2023

Conversation

shuding
Copy link
Member

@shuding shuding commented Oct 26, 2023

There could be CSS files emitted in these chunks so both manifests need to filter them out. This fixes app dir - css css support chunks should bundle css resources into chunks.

@shuding shuding requested review from timneutkens, ijjk, huozhi and a team as code owners October 26, 2023 06:15
@ijjk ijjk added Turbopack Related to Turbopack with Next.js. created-by: Next.js team PRs by the Next.js team. type: next labels Oct 26, 2023
@ijjk
Copy link
Member

ijjk commented Oct 26, 2023

Failing test suites

Commit: 5e7bd03

pnpm test test/integration/prerender-export/test/index.test.js

Expand output

● Test suite failed to run

thrown: "Exceeded timeout of 60000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  217 |       })
  218 |
> 219 |       afterAll(async () => {
      |       ^
  220 |         if (app) {
  221 |           await stopApp(app)
  222 |         }

  at afterAll (integration/prerender-export/test/index.test.js:219:7)
  at describe (integration/prerender-export/test/index.test.js:209:5)
  at integration/prerender-export/test/index.test.js:208:52
  at Object.describe (integration/prerender-export/test/index.test.js:207:1)

Read more about building and testing Next.js in contributing.md.

@ijjk
Copy link
Member

ijjk commented Oct 26, 2023

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js shu/b572 Change
buildDuration 10.3s 10.1s N/A
buildDurationCached 6.1s 6s N/A
nodeModulesSize 175 MB 175 MB ✓
nextStartRea..uration (ms) 420ms 420ms ✓
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js shu/b572 Change
199-HASH.js gzip 32.4 kB 32.4 kB N/A
3f784ff6-HASH.js gzip 53.2 kB 53.2 kB N/A
99.HASH.js gzip 182 B 182 B ✓
framework-HASH.js gzip 45.5 kB 45.5 kB ✓
main-app-HASH.js gzip 254 B 252 B N/A
main-HASH.js gzip 35.3 kB 35.4 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 45.7 kB 45.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js shu/b572 Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js shu/b572 Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.59 kB 2.59 kB ✓
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 369 B 369 B ✓
image-HASH.js gzip 4.38 kB 4.38 kB N/A
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 316 B 318 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 319 B 319 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.99 kB 3.99 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js shu/b572 Change
_buildManifest.js gzip 484 B 482 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js shu/b572 Change
index.html gzip 528 B 529 B N/A
link.html gzip 540 B 542 B N/A
withRouter.html gzip 523 B 525 B N/A
Overall change 0 B 0 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js shu/b572 Change
edge-ssr.js gzip 96 kB 96 kB N/A
page.js gzip 140 kB 140 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js shu/b572 Change
middleware-b..fest.js gzip 626 B 621 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 25.6 kB 25.6 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB ✓
Overall change 1.92 kB 1.92 kB ✓
Commit: 5e7bd03

@sokra sokra merged commit 618d674 into canary Oct 26, 2023
@sokra sokra deleted the shu/b572 branch October 26, 2023 06:31
@github-actions github-actions bot added the locked label Nov 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sokra sokra sokra approved these changes

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@huozhi huozhi Awaiting requested review from huozhi

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. locked Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shuding @ijjk @sokra